src/type-info.cc - Issue 9664070: Don't take UnkownOSRValues into account when infering Phi's representation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.cc

Issue 9664070: Don't take UnkownOSRValues into account when infering Phi's representation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: improve representation inference for phis with constants Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/type-info.cc

diff --git a/src/type-info.cc b/src/type-info.cc

index fa479b2e515b5c811b30c67bae9ce4c3fd4c9e09..7ed18a591ff53543a214925e1af7a2f47c118c39 100644

--- a/src/type-info.cc

+++ b/src/type-info.cc

@@ -368,6 +368,10 @@ TypeInfo TypeFeedbackOracle::BinaryType(BinaryOperation* expr) {

case BinaryOpIC::SMI:

switch (result_type) {

case BinaryOpIC::UNINITIALIZED:

+ if (expr->op() == Token::DIV) {

+ return TypeInfo::Double();

+ }

+ return TypeInfo::Smi();

case BinaryOpIC::SMI:

return TypeInfo::Smi();

case BinaryOpIC::INT32:

« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »