Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 9662064: Remove static Mutex from math function intializers. (Closed)

Created:
8 years, 9 months ago by Yang
Modified:
8 years, 9 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Remove static Mutex from math function intializers. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11015

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M src/platform-posix.cc View 1 chunk +7 lines, -8 lines 2 comments Download
M src/platform-win32.cc View 1 2 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
PTAL.
8 years, 9 months ago (2012-03-12 15:36:08 UTC) #1
fschneider
https://chromiumcodereview.appspot.com/9662064/diff/2001/src/platform-posix.cc File src/platform-posix.cc (right): https://chromiumcodereview.appspot.com/9662064/diff/2001/src/platform-posix.cc#newcode133 src/platform-posix.cc:133: void init_fast_##name##_function() { \ I wonder if you can ...
8 years, 9 months ago (2012-03-12 16:06:40 UTC) #2
fschneider
8 years, 9 months ago (2012-03-12 16:25:46 UTC) #3
lgtm

https://chromiumcodereview.appspot.com/9662064/diff/2001/src/platform-posix.cc
File src/platform-posix.cc (right):

https://chromiumcodereview.appspot.com/9662064/diff/2001/src/platform-posix.c...
src/platform-posix.cc:135: MemoryBarrier();                                     
 \
You can remove this since CallOnce already has MemoryBarrier builtin.

Powered by Google App Engine
This is Rietveld 408576698