Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: src/platform-posix.cc

Issue 9662064: Remove static Mutex from math function intializers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/platform-win32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 121
122 // ---------------------------------------------------------------------------- 122 // ----------------------------------------------------------------------------
123 // Math functions 123 // Math functions
124 124
125 double modulo(double x, double y) { 125 double modulo(double x, double y) {
126 return fmod(x, y); 126 return fmod(x, y);
127 } 127 }
128 128
129 129
130 static Mutex* math_function_mutex = OS::CreateMutex();
131
132 #define UNARY_MATH_FUNCTION(name, generator) \ 130 #define UNARY_MATH_FUNCTION(name, generator) \
133 static UnaryMathFunction fast_##name##_function = NULL; \ 131 static UnaryMathFunction fast_##name##_function = NULL; \
132 V8_DECLARE_ONCE(fast_##name##_init_once); \
133 void init_fast_##name##_function() { \
fschneider 2012/03/12 16:06:40 I wonder if you can make this part of InitializeOn
134 fast_##name##_function = generator; \
135 MemoryBarrier(); \
fschneider 2012/03/12 16:25:46 You can remove this since CallOnce already has Mem
136 } \
134 double fast_##name(double x) { \ 137 double fast_##name(double x) { \
135 if (fast_##name##_function == NULL) { \ 138 CallOnce(&fast_##name##_init_once, \
136 ScopedLock lock(math_function_mutex); \ 139 &init_fast_##name##_function); \
137 UnaryMathFunction temp = generator; \
138 MemoryBarrier(); \
139 fast_##name##_function = temp; \
140 } \
141 return (*fast_##name##_function)(x); \ 140 return (*fast_##name##_function)(x); \
142 } 141 }
143 142
144 UNARY_MATH_FUNCTION(sin, CreateTranscendentalFunction(TranscendentalCache::SIN)) 143 UNARY_MATH_FUNCTION(sin, CreateTranscendentalFunction(TranscendentalCache::SIN))
145 UNARY_MATH_FUNCTION(cos, CreateTranscendentalFunction(TranscendentalCache::COS)) 144 UNARY_MATH_FUNCTION(cos, CreateTranscendentalFunction(TranscendentalCache::COS))
146 UNARY_MATH_FUNCTION(tan, CreateTranscendentalFunction(TranscendentalCache::TAN)) 145 UNARY_MATH_FUNCTION(tan, CreateTranscendentalFunction(TranscendentalCache::TAN))
147 UNARY_MATH_FUNCTION(log, CreateTranscendentalFunction(TranscendentalCache::LOG)) 146 UNARY_MATH_FUNCTION(log, CreateTranscendentalFunction(TranscendentalCache::LOG))
148 UNARY_MATH_FUNCTION(sqrt, CreateSqrtFunction()) 147 UNARY_MATH_FUNCTION(sqrt, CreateSqrtFunction())
149 148
150 #undef MATH_FUNCTION 149 #undef MATH_FUNCTION
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
515 return ntohl(value); 514 return ntohl(value);
516 } 515 }
517 516
518 517
519 Socket* OS::CreateSocket() { 518 Socket* OS::CreateSocket() {
520 return new POSIXSocket(); 519 return new POSIXSocket();
521 } 520 }
522 521
523 522
524 } } // namespace v8::internal 523 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/platform-win32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698