chrome/renderer/resources/extensions/browser_action_custom_bindings.js - Issue 9657026: Revert 125801 - Implement a module system for the extension bindings JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

Issue 9657026: Revert 125801 - Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/app.js ('k') | chrome/renderer/resources/extensions/chrome_private_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

===================================================================

--- chrome/renderer/resources/extensions/browser_action_custom_bindings.js (revision 125813)

+++ chrome/renderer/resources/extensions/browser_action_custom_bindings.js (working copy)

@@ -4,9 +4,11 @@

// Custom bindings for the browserAction API.

-var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

+(function() {

-chromeHidden.registerCustomHook('browserAction', function(bindingsAPI) {

+native function GetChromeHidden();

+GetChromeHidden().registerCustomHook('browserAction', function(bindingsAPI) {

var apiFunctions = bindingsAPI.apiFunctions;

var setIcon = bindingsAPI.setIcon;

@@ -14,3 +16,5 @@

setIcon(details, this.name, this.definition.parameters, 'browser action');

});

+})();