Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6336)

Unified Diff: chrome/renderer/extensions/context_menus_custom_bindings.cc

Issue 9657026: Revert 125801 - Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/context_menus_custom_bindings.cc
===================================================================
--- chrome/renderer/extensions/context_menus_custom_bindings.cc (revision 125813)
+++ chrome/renderer/extensions/context_menus_custom_bindings.cc (working copy)
@@ -7,9 +7,19 @@
#include "grit/renderer_resources.h"
#include "v8/include/v8.h"
-namespace {
+namespace extensions {
-v8::Handle<v8::Value> GetNextContextMenuId(const v8::Arguments& args) {
+ContextMenusCustomBindings::ContextMenusCustomBindings(
+ int dependency_count,
+ const char** dependencies)
+ : ChromeV8Extension(
+ "extensions/context_menus_custom_bindings.js",
+ IDR_CONTEXT_MENUS_CUSTOM_BINDINGS_JS,
+ dependency_count,
+ dependencies,
+ NULL) {}
+
+static v8::Handle<v8::Value> GetNextContextMenuId(const v8::Arguments& args) {
// Note: this works because contextMenus.create() only works in the
// extension process. If that API is opened up to content scripts, this
// will need to change. See crbug.com/77023
@@ -17,13 +27,12 @@
return v8::Integer::New(next_context_menu_id++);
}
-} // namespace
+v8::Handle<v8::FunctionTemplate> ContextMenusCustomBindings::GetNativeFunction(
+ v8::Handle<v8::String> name) {
+ if (name->Equals(v8::String::New("GetNextContextMenuId")))
+ return v8::FunctionTemplate::New(GetNextContextMenuId);
-namespace extensions {
-
-ContextMenusCustomBindings::ContextMenusCustomBindings()
- : ChromeV8Extension(NULL) {
- RouteStaticFunction("GetNextContextMenuId", &GetNextContextMenuId);
+ return ChromeV8Extension::GetNativeFunction(name);
}
} // extensions
« no previous file with comments | « chrome/renderer/extensions/context_menus_custom_bindings.h ('k') | chrome/renderer/extensions/custom_bindings_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698