Make helper app, get closer to working content shell.

Make helper app, get closer to working content shell.

BUG=115784
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125921

[Mark Mentovai, 2012-03-09 17:49:26]

https://chromiumcodereview.appspot.com/9656002/diff/1/chrome/chrome_exe.gypi
File chrome/chrome_exe.gypi (right):

https://chromiumcodereview.appspot.com/9656002/diff/1/chrome/chrome_exe.gypi#...
chrome/chrome_exe.gypi:365:
'${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH}/Versions/<(version_full)',
I don’t feel fantastic about putting things that you want the shell to expand
right into a GYP action. That these are passed to a shell by GYP is sort of
subject to change.

The best solution would be to have a small sh script for each of these. The
script would invoke make_more_helpers.sh, and would of course be free to access
the environment variables in precisely the way that the shell does that.

Another option is to make make_more_helpers.sh always add
${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH} as it did before, but not make it
always add Versions. Then, you’d pass Versions/<(version_full) as the argument
here, and simply Frameworks in the other file.

https://chromiumcodereview.appspot.com/9656002/diff/1/content/content_shell.gypi
File content/content_shell.gypi (right):

https://chromiumcodereview.appspot.com/9656002/diff/1/content/content_shell.g...
content/content_shell.gypi:324:
'${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH}/Frameworks',
Refer to the other note.

https://chromiumcodereview.appspot.com/9656002/diff/1/content/shell/shell_bro...
File content/shell/shell_browser_main_mac.mm (right):

https://chromiumcodereview.appspot.com/9656002/diff/1/content/shell/shell_bro...
content/shell/shell_browser_main_mac.mm:21: }  // namespace
This comment says you’re ending an anonymous namespace. This line should be:

}  // namespace content

https://chromiumcodereview.appspot.com/9656002/diff/1/content/shell/shell_mai...
File content/shell/shell_main_delegate.cc (right):

https://chromiumcodereview.appspot.com/9656002/diff/1/content/shell/shell_mai...
content/shell/shell_main_delegate.cc:53: }
This one should be

}  // namespace

[Avi (use Gerrit), 2012-03-09 22:05:59]

https://chromiumcodereview.appspot.com/9656002/diff/1/chrome/chrome_exe.gypi
File chrome/chrome_exe.gypi (right):

https://chromiumcodereview.appspot.com/9656002/diff/1/chrome/chrome_exe.gypi#...
chrome/chrome_exe.gypi:365:
'${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH}/Versions/<(version_full)',
On 2012/03/09 17:49:26, Mark Mentovai wrote:
> I don’t feel fantastic about putting things that you want the shell to expand
> right into a GYP action. That these are passed to a shell by GYP is sort of
> subject to change.
> 
> The best solution would be to have a small sh script for each of these. The
> script would invoke make_more_helpers.sh, and would of course be free to
access
> the environment variables in precisely the way that the shell does that.
> 
> Another option is to make make_more_helpers.sh always add
> ${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH} as it did before, but not make
it
> always add Versions. Then, you’d pass Versions/<(version_full) as the argument
> here, and simply Frameworks in the other file.

Done.

https://chromiumcodereview.appspot.com/9656002/diff/1/content/shell/shell_bro...
File content/shell/shell_browser_main_mac.mm (right):

https://chromiumcodereview.appspot.com/9656002/diff/1/content/shell/shell_bro...
content/shell/shell_browser_main_mac.mm:21: }  // namespace
On 2012/03/09 17:49:26, Mark Mentovai wrote:
> This comment says you’re ending an anonymous namespace. This line should be:
> 
> }  // namespace content

Done.

https://chromiumcodereview.appspot.com/9656002/diff/1/content/shell/shell_mai...
File content/shell/shell_main_delegate.cc (right):

https://chromiumcodereview.appspot.com/9656002/diff/1/content/shell/shell_mai...
content/shell/shell_main_delegate.cc:53: }
On 2012/03/09 17:49:26, Mark Mentovai wrote:
> This one should be
> 
> }  // namespace

Done.

[Mark Mentovai, 2012-03-09 22:18:29]

LGTM

Are you actually hooked up to use the EH and NP helpers yet? (Just for
curiosity’s sake.)

[Avi (use Gerrit), 2012-03-09 22:35:21]

On 2012/03/09 22:18:29, Mark Mentovai wrote:
> LGTM
> 
> Are you actually hooked up to use the EH and NP helpers yet? (Just for
> curiosity’s sake.)

That's in there already in content/common/child_process_host_impl.cc.

[Mark Mentovai, 2012-03-09 22:48:51]

That’s what I thought. Great!