content/shell/shell_browser_main_mac.mm - Issue 9656002: Make helper app, get closer to working content shell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/shell_browser_main_mac.mm

Issue 9656002: Make helper app, get closer to working content shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/shell/shell_browser_main.h"

	6

	7 #import <Cocoa/Cocoa.h>

	8

	9 #include "base/mac/bundle_locations.h"

	10 #include "base/memory/scoped_nsobject.h"

	11

	12 namespace content {

	13

	14 void ShellBrowserMainParts::PreMainMessageLoopStart() {

	15 scoped_nsobject<NSNib>

	16 nib([[NSNib alloc] initWithNibNamed:@"MainMenu"

	17 bundle:base::mac::FrameworkBundle()]);

	18 [nib instantiateNibWithOwner:NSApp topLevelObjects:nil];

	19 }

	20

	21 } // namespace
	Mark Mentovai 2012/03/09 17:49:26 This comment says you’re ending an anonymous names This comment says you’re ending an anonymous namespace. This line should be: } // namespace content Avi (use Gerrit) 2012/03/09 22:05:59 Done. Show quoted text On 2012/03/09 17:49:26, Mark Mentovai wrote: > This comment says you’re ending an anonymous namespace. This line should be: > > } // namespace content Done.
OLD	NEW