Chromium Code Reviews Chromium Code Reviews
Issue
9655017:
Implement WebKitPlatformSupport::canAccelerate2dCanvas (Closed)
DescriptionImplement WebKitPlatformSupport::canAccelerate2dCanvas
We do not want to use the accelerated 2d canvas path if we can lose a context
"too easily" - for example due to the screensaver turning on - or if we're using
a software rendering backend for GL contexts (swiftshader). The way these conditions
are currently checked for are awkard and racy. This adds an explicit check that
WebKit calls prior to instantiating an accelerated context for canvas. This
does two things:
1.) Attempt to spin up the GpuChannelHost. If we can't do this, then we definitely
don't need to bother. Note that if the GPU process crashes this will establish a
connection to the new GPU process.
2.) Query the can_lose_context and software_rendering bits from the new channel.
These are both properties of the GPU process, not of individual contexts, so we
don't need to have a particular context ready in order to do this.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126558
Patch Set 1 #Patch Set 2 : fix clang warning about inline virtual function body #
Total comments: 3
Patch Set 3 : move canAccelerate.. call next to createOffscreenGraphicsContext3D call #Messages
Total messages: 12 (0 generated)
|
