Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 9649022: linux: Explicitly include gmodule-2.0 in the list for glib/gtk dependency. (Closed)

Created:
8 years, 9 months ago by sadrul
Modified:
8 years, 9 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

linux: Explicitly include gmodule-2.0 in the list for glib/gtk dependency. BUG=115799 TEST=bots remain non-grumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126148

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M build/linux/system.gyp View 1 2 2 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
maybe you can review? :) This should be OK? the bots seem to be happy ...
8 years, 9 months ago (2012-03-09 05:08:45 UTC) #1
Evan Martin
Can you use a gyp variable to centralize this list of libraries? Then you could ...
8 years, 9 months ago (2012-03-09 22:24:05 UTC) #2
sadrul
On 2012/03/09 22:24:05, Evan Martin wrote: > Can you use a gyp variable to centralize ...
8 years, 9 months ago (2012-03-12 10:22:42 UTC) #3
Evan Martin
8 years, 9 months ago (2012-03-12 16:04:29 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698