Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2533)

Unified Diff: build/linux/system.gyp

Issue 9649022: linux: Explicitly include gmodule-2.0 in the list for glib/gtk dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/linux/system.gyp
diff --git a/build/linux/system.gyp b/build/linux/system.gyp
index 60a438c673b537639690d528c498fd0ac73bd9d9..caf5062b8a43aacad96831d45049d48b5f2541bb 100644
--- a/build/linux/system.gyp
+++ b/build/linux/system.gyp
@@ -32,33 +32,38 @@
'target_name': 'gtk',
'type': 'none',
'toolsets': ['host', 'target'],
+ 'variables': {
+ # gtk requires gmodule, but it does not list it as a dependency in some
+ # misconfigured systems.
+ 'gtk_packages': 'gmodule-2.0 gtk+-2.0 gthread-2.0',
+ },
'conditions': [
['_toolset=="target"', {
'direct_dependent_settings': {
'cflags': [
- '<!@(<(pkg-config) --cflags gtk+-2.0 gthread-2.0)',
+ '<!@(<(pkg-config) --cflags <(gtk_packages))',
],
},
'link_settings': {
'ldflags': [
- '<!@(<(pkg-config) --libs-only-L --libs-only-other gtk+-2.0 gthread-2.0)',
+ '<!@(<(pkg-config) --libs-only-L --libs-only-other <(gtk_packages))',
],
'libraries': [
- '<!@(<(pkg-config) --libs-only-l gtk+-2.0 gthread-2.0)',
+ '<!@(<(pkg-config) --libs-only-l <(gtk_packages))',
],
},
}, {
'direct_dependent_settings': {
'cflags': [
- '<!@(pkg-config --cflags gtk+-2.0 gthread-2.0)',
+ '<!@(pkg-config --cflags <(gtk_packages))',
],
},
'link_settings': {
'ldflags': [
- '<!@(pkg-config --libs-only-L --libs-only-other gtk+-2.0 gthread-2.0)',
+ '<!@(pkg-config --libs-only-L --libs-only-other <(gtk_packages))',
],
'libraries': [
- '<!@(pkg-config --libs-only-l gtk+-2.0 gthread-2.0)',
+ '<!@(pkg-config --libs-only-l <(gtk_packages))',
],
},
}],
@@ -494,33 +499,36 @@
'target_name': 'glib',
'type': 'none',
'toolsets': ['host', 'target'],
+ 'variables': {
+ 'glib_packages': 'glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0',
+ },
'conditions': [
['_toolset=="target"', {
'direct_dependent_settings': {
'cflags': [
- '<!@(<(pkg-config) --cflags glib-2.0 gobject-2.0 gthread-2.0)',
+ '<!@(<(pkg-config) --cflags <(glib_packages))',
],
},
'link_settings': {
'ldflags': [
- '<!@(<(pkg-config) --libs-only-L --libs-only-other glib-2.0 gobject-2.0 gthread-2.0)',
+ '<!@(<(pkg-config) --libs-only-L --libs-only-other <(glib_packages))',
],
'libraries': [
- '<!@(<(pkg-config) --libs-only-l glib-2.0 gobject-2.0 gthread-2.0)',
+ '<!@(<(pkg-config) --libs-only-l <(glib_packages))',
],
},
}, {
'direct_dependent_settings': {
'cflags': [
- '<!@(pkg-config --cflags glib-2.0 gobject-2.0 gthread-2.0)',
+ '<!@(pkg-config --cflags <(glib_packages))',
],
},
'link_settings': {
'ldflags': [
- '<!@(pkg-config --libs-only-L --libs-only-other glib-2.0 gobject-2.0 gthread-2.0)',
+ '<!@(pkg-config --libs-only-L --libs-only-other <(glib_packages))',
],
'libraries': [
- '<!@(pkg-config --libs-only-l glib-2.0 gobject-2.0 gthread-2.0)',
+ '<!@(pkg-config --libs-only-l <(glib_packages))',
],
},
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698