Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 9644001: Fix minifier to distinguish regexps from divisions (to some extent). (Closed)

Created:
8 years, 9 months ago by rossberg
Modified:
8 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix minifier to distinguish regexps from divisions (to some extent). Rrraaa, I have to say, doing program rewriting via regexp rules is an inherently broken idea... R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/object-is.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/jsmin.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rossberg
8 years, 9 months ago (2012-03-08 16:31:41 UTC) #1
Michael Starzinger
8 years, 9 months ago (2012-03-08 16:33:56 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698