tools/jsmin.py - Issue 9644001: Fix minifier to distinguish regexps from divisions (to some extent).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/jsmin.py

Issue 9644001: Fix minifier to distinguish regexps from divisions (to some extent). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/jsmin.py

diff --git a/tools/jsmin.py b/tools/jsmin.py

index 646bf143a5aae1c6182f8554829a72e01629c349..e82f3d031e884c92767e2714c6a191e7c25b526e 100644

--- a/tools/jsmin.py

+++ b/tools/jsmin.py

@@ -232,7 +232,9 @@ class JavaScriptMinifier(object):

# A regexp that matches a regexp literal surrounded by /slashes/.

# Don't allow a regexp to have a ) before the first ( since that's a

# syntax error and it's probably just two unrelated slashes.

- slash_quoted_regexp = r"/(?:(?=\()|(?:[^()/\\]|\\.)+)(?:\([^/\\]|\\.)*/"

+ # Also don't allow it to come after anything that can only be the

+ # end of a primary expression.

+ slash_quoted_regexp = r"(?<![\w$'\")\]])/(?:(?=\()|(?:[^()/\\]|\\.)+)(?:\([^/\\]|\\.)*/"

# Replace multiple spaces with a single space.

line = re.sub("|".join([double_quoted_string,

single_quoted_string,

« no previous file with comments | « test/mjsunit/object-is.js ('k') | no next file » | no next file with comments »