Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: frog/leg/typechecker.dart

Issue 9642001: Make string juxtaposition combine properly with string interpolations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/leg/tree/visitors.dart ('k') | frog/tests/leg_only/src/LiteralStringJuxtapositionTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/typechecker.dart
diff --git a/frog/leg/typechecker.dart b/frog/leg/typechecker.dart
index c3424c3f0c970031f54ef25e160cb291e4fb95db..ef555b2a420e88e1cba9224a75c35fbeffce3301 100644
--- a/frog/leg/typechecker.dart
+++ b/frog/leg/typechecker.dart
@@ -499,7 +499,9 @@ class TypeCheckerVisitor implements Visitor<Type> {
return stringType;
}
- Type visitLiteralStringJuxtaposition(LiteralStringJuxtaposition node) {
+ Type visitStringJuxtaposition(StringJuxtaposition node) {
+ analyze(node.first);
+ analyze(node.second);
return stringType;
}
« no previous file with comments | « frog/leg/tree/visitors.dart ('k') | frog/tests/leg_only/src/LiteralStringJuxtapositionTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698