Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: frog/leg/tree/visitors.dart

Issue 9642001: Make string juxtaposition combine properly with string interpolations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/leg/tree/unparser.dart ('k') | frog/leg/typechecker.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/tree/visitors.dart
diff --git a/frog/leg/tree/visitors.dart b/frog/leg/tree/visitors.dart
index d9e2b4db4e795ec5f1b73db23b32713b1f079b29..2b5305de11267c676b8d7c737904f3fec3f85946 100644
--- a/frog/leg/tree/visitors.dart
+++ b/frog/leg/tree/visitors.dart
@@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.
class AbstractVisitor<R> implements Visitor<R> {
+ const AbstractVisitor();
+
abstract R visitNode(Node node);
R visitBlock(Block node) => visitStatement(node);
@@ -31,10 +33,8 @@ class AbstractVisitor<R> implements Visitor<R> {
R visitLiteralMap(LiteralMap node) => visitExpression(node);
R visitLiteralMapEntry(LiteralMapEntry node) => visitNode(node);
R visitLiteralNull(LiteralNull node) => visitLiteral(node);
- R visitLiteralString(LiteralString node) => visitLiteral(node);
- R visitLiteralStringJuxtaposition(LiteralStringJuxtaposition node) {
- return visitLiteralString(node);
- }
+ R visitLiteralString(LiteralString node) => visitStringNode(node);
+ R visitStringJuxtaposition(Juxtaposition node) => visitStringNode(node);
R visitLoop(Loop node) => visitStatement(node);
R visitModifiers(Modifiers node) => visitNode(node);
R visitNamedArgument(NamedArgument node) => visitExpression(node);
@@ -51,7 +51,8 @@ class AbstractVisitor<R> implements Visitor<R> {
R visitSend(Send node) => visitExpression(node);
R visitSendSet(SendSet node) => visitSend(node);
R visitStatement(Statement node) => visitNode(node);
- R visitStringInterpolation(StringInterpolation node) => visitExpression(node);
+ R visitStringNode(StringNode node) => visitExpression(node);
+ R visitStringInterpolation(StringInterpolation node) => visitStringNode(node);
R visitStringInterpolationPart(StringInterpolationPart node) {
return visitNode(node);
}
« no previous file with comments | « frog/leg/tree/unparser.dart ('k') | frog/leg/typechecker.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698