Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: frog/leg/resolver.dart

Issue 9642001: Make string juxtaposition combine properly with string interpolations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix typo Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/leg/resolver.dart
diff --git a/frog/leg/resolver.dart b/frog/leg/resolver.dart
index 3b3e8a64243d28a4ddc0401f62023f8723c55175..8c365df65f336c233a3167ff3bdcf575314777ec 100644
--- a/frog/leg/resolver.dart
+++ b/frog/leg/resolver.dart
@@ -917,6 +917,10 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
visitLiteralNull(LiteralNull node) {
}
+ visitStringJuxtaposition(StringJuxtaposition node) {
+ if (node.isInterpolation) node.visitChildren(this);
ahe 2012/03/19 15:53:06 Is "if (node.isInterpolation)" a "premature" optim
Lasse Reichstein Nielsen 2012/03/20 09:34:33 Yes. All optimizations not backed by measurement a
+ }
+
visitNodeList(NodeList node) {
for (Link<Node> link = node.nodes; !link.isEmpty(); link = link.tail) {
visit(link.head);

Powered by Google App Engine
This is Rietveld 408576698