Make string juxtaposition combine properly with string interpolations.

frog/leg/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
 }
 
 class TreeElementMapping implements TreeElements {
@@ skipping 899 matching lines @@
 
   visitLiteralBool(LiteralBool node) {
   }
 
   visitLiteralString(LiteralString node) {
   }
 
   visitLiteralNull(LiteralNull node) {
   }
 
+  visitStringJuxtaposition(StringJuxtaposition node) {
+    if (node.isInterpolation) node.visitChildren(this);

[ahe, 2012/03/19 15:53:06]

Is "if (node.isInterpolation)" a "premature" optimization?

[Lasse Reichstein Nielsen, 2012/03/20 09:34:33]

Yes.
All optimizations not backed by measurement are premature.
It used to be a safe and quick check, but after the recent change, making
isInterpolation dynamically computed, it's probably not any faster (apart from
computing isInterpolation so it's cached next time it's read).
I'll remove it.

+  }
+
   visitNodeList(NodeList node) {
     for (Link<Node> link = node.nodes; !link.isEmpty(); link = link.tail) {
       visit(link.head);
     }
   }
 
   visitOperator(Operator node) {
     unimplemented(node, 'operator');
   }
 
@@ skipping 820 matching lines @@
 
   TopScope(LibraryElement library) : super(null, library);
   Element lookup(SourceString name) {
     return library.find(name);
   }
 
   Element add(Element element) {
     throw "Cannot add an element in the top scope";
   }
 }