Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 9641026: Add software audio mixing to the audio utils. (Closed)

Created:
8 years, 9 months ago by enal
Modified:
8 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Add software audio mixing to the audio utils. BUG=114701 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127709

Patch Set 1 #

Total comments: 13

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -3 lines) Patch
M media/audio/audio_util.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M media/audio/audio_util.cc View 1 2 3 chunks +65 lines, -3 lines 0 comments Download
M media/audio/audio_util_unittest.cc View 1 2 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
enal1
Hi Victoria, Can you please review first mixer-related change?
8 years, 9 months ago (2012-03-08 18:50:37 UTC) #1
vrk (LEFT CHROMIUM)
Mostly looks fine; I had some questions, though. https://chromiumcodereview.appspot.com/9641026/diff/1/media/audio/audio_util.cc File media/audio/audio_util.cc (right): https://chromiumcodereview.appspot.com/9641026/diff/1/media/audio/audio_util.cc#newcode244 media/audio/audio_util.cc:244: // ...
8 years, 9 months ago (2012-03-12 18:40:24 UTC) #2
enal1
Addressed everything. https://chromiumcodereview.appspot.com/9641026/diff/1/media/audio/audio_util.cc File media/audio/audio_util.cc (right): https://chromiumcodereview.appspot.com/9641026/diff/1/media/audio/audio_util.cc#newcode244 media/audio/audio_util.cc:244: // TODO(enal): use specialization and intrinsics. On ...
8 years, 9 months ago (2012-03-12 21:20:52 UTC) #3
vrk (LEFT CHROMIUM)
LGTM with nits Sorry for the delay -- forgot this was still out! Feel free ...
8 years, 9 months ago (2012-03-20 00:27:53 UTC) #4
scherkus (not reviewing)
enal: can you update the CL description with the appropriate BUG= for adding mixing support?
8 years, 9 months ago (2012-03-20 14:45:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/9641026/10001
8 years, 9 months ago (2012-03-20 15:58:25 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-20 17:10:25 UTC) #7
Change committed as 127709

Powered by Google App Engine
This is Rietveld 408576698