Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 9638015: Remove ppc and ppc64 architectures from libWebKitSystemInterfaceLeopard.a (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Remove ppc and ppc64 architectures from libWebKitSystemInterfaceLeopard.a It looks like xcode4.3's ld can no longer relink ppc object files (see bug). BUG=117215 TEST=fewer build problems when building with xcode 4.3 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125700

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/apple_webkit/README.chromium View 1 1 chunk +7 lines, -1 line 2 comments Download
M third_party/apple_webkit/libWebKitSystemInterfaceLeopard.a View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
I want to change the adjust_visibility.sh script to error out if it sees a ppc ...
8 years, 9 months ago (2012-03-08 18:03:57 UTC) #1
Robert Sesek
lgtm https://chromiumcodereview.appspot.com/9638015/diff/2001/third_party/apple_webkit/README.chromium File third_party/apple_webkit/README.chromium (right): https://chromiumcodereview.appspot.com/9638015/diff/2001/third_party/apple_webkit/README.chromium#newcode5 third_party/apple_webkit/README.chromium:5: Security Critical: Yes What does this mean?
8 years, 9 months ago (2012-03-08 18:05:54 UTC) #2
Nico
Thanks! https://chromiumcodereview.appspot.com/9638015/diff/2001/third_party/apple_webkit/README.chromium File third_party/apple_webkit/README.chromium (right): https://chromiumcodereview.appspot.com/9638015/diff/2001/third_party/apple_webkit/README.chromium#newcode5 third_party/apple_webkit/README.chromium:5: Security Critical: Yes On 2012/03/08 18:05:56, rsesek wrote: ...
8 years, 9 months ago (2012-03-08 18:07:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9638015/2001
8 years, 9 months ago (2012-03-08 18:07:28 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-08 22:32:29 UTC) #5
Try job failure for 9638015-2001 (retry) (retry) on win_rel for step "compile"
(clobber build).
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698