Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5207)

Unified Diff: chrome/browser/notifications/balloon_collection_impl.h

Issue 9621020: Fix 117074: Panels [WIN]: Crash data shows a stack trace consistently involving PanelManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/balloon_collection_impl.h
diff --git a/chrome/browser/notifications/balloon_collection_impl.h b/chrome/browser/notifications/balloon_collection_impl.h
index 749c9e0180edda08580454abe801627a5fe8e23a..6ebb20977a03c4bdd1c0cccaf6828b1b05d0f871 100644
--- a/chrome/browser/notifications/balloon_collection_impl.h
+++ b/chrome/browser/notifications/balloon_collection_impl.h
@@ -143,6 +143,8 @@ class BalloonCollectionImpl : public BalloonCollection,
// to be repositioned.
bool ComputeOffsetToMoveAbovePanels(const gfx::Rect& panel_bounds);
+ void enable_panel_offset() { panel_offset_enabled_ = true; }
+
private:
// Layout parameters
int VerticalEdgeMargin() const;
@@ -161,6 +163,10 @@ class BalloonCollectionImpl : public BalloonCollection,
Placement placement_;
gfx::Rect work_area_;
+ // The flag that indicates that the panel offset computation should be
+ // performed.
+ bool panel_offset_enabled_;
jennb 2012/03/08 04:34:18 panel_offset_enabled_ is rather vague. How about n
jianli 2012/03/08 18:26:45 Done.
+
// The offset that guarantees that the notificaitions shown in the
// lower-right or lower-left corner of the screen will go above currently
// shown panels and will not be obscured by them.

Powered by Google App Engine
This is Rietveld 408576698