Fix 117074: Panels [WIN]: Crash data shows a stack trace consistently involving PanelManager

chrome/browser/notifications/balloon_collection_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Handles the visible notification (or balloons).
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_BALLOON_COLLECTION_IMPL_H_
 #define CHROME_BROWSER_NOTIFICATIONS_BALLOON_COLLECTION_IMPL_H_
 #pragma once
 
@@ skipping 125 matching lines @@
     gfx::Point OffScreenLocation() const;
 
     // Returns true if the layout requires offsetting for keeping the close
     // buttons under the cursor during rapid-close interaction.
     bool RequiresOffsets() const;
 
     // Returns true if there is change to the offset that requires the balloons
     // to be repositioned.
     bool ComputeOffsetToMoveAbovePanels(const gfx::Rect& panel_bounds);
 
+    void enable_panel_offset() { panel_offset_enabled_ = true; }
+
    private:
     // Layout parameters
     int VerticalEdgeMargin() const;
     int HorizontalEdgeMargin() const;
     int InterBalloonMargin() const;
 
     bool NeedToMoveAboveLeftSidePanels() const;
     bool NeedToMoveAboveRightSidePanels() const;
 
     // Minimum and maximum size of balloon content.
     static const int kBalloonMinWidth = 300;
     static const int kBalloonMaxWidth = 300;
     static const int kBalloonMinHeight = 24;
     static const int kBalloonMaxHeight = 160;
 
     Placement placement_;
     gfx::Rect work_area_;
 
+    // The flag that indicates that the panel offset computation should be
+    // performed.
+    bool panel_offset_enabled_;

[jennb, 2012/03/08 04:34:18]

panel_offset_enabled_ is rather vague. How about need_to_compute_panel_offset_ ?

[jianli, 2012/03/08 18:26:45]

Done.

+
     // The offset that guarantees that the notificaitions shown in the
     // lower-right or lower-left corner of the screen will go above currently
     // shown panels and will not be obscured by them.
     int offset_to_move_above_panels_;
 
     DISALLOW_COPY_AND_ASSIGN(Layout);
   };
 
   // Creates a new balloon. Overridable by derived classes and unit tests.
   // The caller is responsible for freeing the pointer returned.
@@ skipping 51 matching lines @@
   base::WeakPtrFactory<BalloonCollectionImpl> reposition_factory_;
 
   // Is the balloon collection currently listening for UI events?
   bool added_as_message_loop_observer_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(BalloonCollectionImpl);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_BALLOON_COLLECTION_IMPL_H_