Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 9617018: Pepper: Make C++ wrappers for PPB_AudioConfig backwards compatible. (Closed)

Created:
8 years, 9 months ago by viettrungluu
Modified:
8 years, 9 months ago
Reviewers:
brettw, yzshen1
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Make C++ wrappers for PPB_AudioConfig backwards compatible. This makes the wrappers work transparently with both versions 1.1 and 1.0 of the interface. (The compatibility is needed for Pepper Flash to use the wrappers; Pepper Flash needs to work with M18 until M19 ships, at which point we can remove the 1.0-compatibility.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125310

Patch Set 1 #

Total comments: 2

Patch Set 2 : d'oh #

Patch Set 3 : d'oh #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M ppapi/cpp/audio_config.cc View 1 2 4 chunks +29 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
yzshen -> review, brettw -> OWNERS stamp
8 years, 9 months ago (2012-03-06 20:51:25 UTC) #1
yzshen1
lgtm https://chromiumcodereview.appspot.com/9617018/diff/1/ppapi/cpp/audio_config.cc File ppapi/cpp/audio_config.cc (right): https://chromiumcodereview.appspot.com/9617018/diff/1/ppapi/cpp/audio_config.cc#newcode40 ppapi/cpp/audio_config.cc:40: if (has_interface<PPB_AudioConfig_1_0>()) { You need an 'else' here. ...
8 years, 9 months ago (2012-03-06 20:54:34 UTC) #2
viettrungluu
https://chromiumcodereview.appspot.com/9617018/diff/1/ppapi/cpp/audio_config.cc File ppapi/cpp/audio_config.cc (right): https://chromiumcodereview.appspot.com/9617018/diff/1/ppapi/cpp/audio_config.cc#newcode40 ppapi/cpp/audio_config.cc:40: if (has_interface<PPB_AudioConfig_1_0>()) { On 2012/03/06 20:54:34, yzshen1 wrote: > ...
8 years, 9 months ago (2012-03-06 22:17:21 UTC) #3
brettw
lgtm
8 years, 9 months ago (2012-03-07 00:17:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/9617018/5003
8 years, 9 months ago (2012-03-07 01:13:09 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-07 03:13:32 UTC) #6
Change committed as 125310

Powered by Google App Engine
This is Rietveld 408576698