Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 9616035: Increase priority of GPU presenter threads (Closed)

Created:
8 years, 9 months ago by jbauman
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Increase priority if GPU presenter threads This helps keep consistent frame times by moving the StretchRect as early as possible in the queue, so waiting for it to finish doesn't involve waiting for lots of expensive GPU-process commands to finish. BUG=112349 TEST=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/gfx/surface/accelerated_surface_win.cc View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
jbauman
8 years, 9 months ago (2012-03-06 22:13:15 UTC) #1
apatrick_chromium
This seems fine. Can you hold off until I have landed my fix for 116175 ...
8 years, 9 months ago (2012-03-06 22:20:31 UTC) #2
jbauman
8 years, 9 months ago (2012-03-06 22:22:39 UTC) #3
On 2012/03/06 22:20:31, apatrick_chromium wrote:
> This seems fine. Can you hold off until I have landed my fix for 116175
though?
> It should be in today.

Sure. Actually, I may hold off on this to make sure it doesn't cause frames to
have alternating lengths.
> 
>
https://chromiumcodereview.appspot.com/9616035/diff/1/ui/gfx/surface/accelera...
> File ui/gfx/surface/accelerated_surface_win.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9616035/diff/1/ui/gfx/surface/accelera...
> ui/gfx/surface/accelerated_surface_win.cc:329:
device_->SetGPUThreadPriority(7);
> This isn't going to give this thread higher GPU priority than the DWM, thereby
> bricking lots of machines is it? :) Does 1 work?

I suspect DWM has priority infinity. However, I can sure try to reduce it.

Powered by Google App Engine
This is Rietveld 408576698