Issue 9616002: Update typeNameOf to treat Window as DOMWindow on Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9616002: Update typeNameOf to treat Window as DOMWindow on Chrome. (Closed)

Created:
8 years, 9 months ago by kasperl

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Update typeNameOf to treat Window as DOMWindow on Chrome. R=ngeoffray@google.com BUG=http://dartbug.com/1923 TEST= Committed: https://code.google.com/p/dart/source/detail?r=5008

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -119 lines)			Patch
M	frog/corejs.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	frog/leg/native_emitter.dart	View	1	1 chunk	+50 lines, -21 lines	0 comments	Download
M	frog/minfrog	View	1	6 chunks	+103 lines, -97 lines	0 comments	Download

Total messages: 3 (0 generated)

sra1

Remember to run ./presubmit.py and include the changes to minfrog in the CL. minfrog is ...

8 years, 9 months ago (2012-03-06 08:14:07 UTC) #2

LGTM! Thanks Kasper for also taking care of leg.