frog/corejs.dart - Issue 9616002: Update typeNameOf to treat Window as DOMWindow on Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/corejs.dart

Issue 9616002: Update typeNameOf to treat Window as DOMWindow on Chrome. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update minfrog and make string raw. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/corejs.dart

diff --git a/frog/corejs.dart b/frog/corejs.dart

index 88b82977efe1b7d11ab90b631dd7b5b68b1d6023..2f6d6d2421f91e9ade378fa973aeac153674c197 100644

--- a/frog/corejs.dart

+++ b/frog/corejs.dart

@@ -408,7 +408,9 @@ $defProp(Object.prototype, '$typeNameOf', (function() {

}

function chrome$typeNameOf() {

- return this.constructor.name;

+ var name = this.constructor.name;

+ if (name == 'Window') return 'DOMWindow';

+ return name;

}

function firefox$typeNameOf() {

« no previous file with comments | « no previous file | frog/leg/native_emitter.dart » ('j') | no next file with comments »