Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 9609024: Reland 124817 - Take extensions out of Profile into a profile-keyed service, ExtensionSystem. (Closed)

Created:
8 years, 9 months ago by Yoyo Zhou
Modified:
8 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, cbentzel+watch_chromium.org, akalin, Raghu Simha, ncarter (slow), tburkard+watch_chromium.org, achuith+watch_chromium.org, kkania, mihaip+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, robertshield, tim (not reviewing), brettw-cc_chromium.org, darin-cc_chromium.org, rginda+watch_chromium.org, mmenke, Ted C, Yaron
Visibility:
Public.

Description

Reland 124817 - Take extensions out of Profile into a profile-keyed service, ExtensionSystem. Move InitExtensions into ExtensionSystem. Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go. New: PrerenderManagerFactory DependsOn ExtensionSystemFactory. BUG=104095 TEST=Open and close an incognito window; should not crash. TBR=aa@chromium.org,akalin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125805

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+981 lines, -435 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_handler.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 8 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 13 chunks +40 lines, -38 lines 0 comments Download
A chrome/browser/extensions/extension_system.h View 1 chunk +168 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_system.cc View 1 chunk +284 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_system_factory.h View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_system_factory.cc View 1 chunk +87 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 2 chunks +15 lines, -8 lines 0 comments Download
A chrome/browser/extensions/test_extension_system.h View 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/extensions/test_extension_system.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M chrome/browser/intents/web_intents_registry_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 4 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 7 chunks +18 lines, -33 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 6 chunks +13 lines, -35 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 6 chunks +3 lines, -30 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 9 chunks +11 lines, -163 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 5 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 5 chunks +1 line, -26 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 6 chunks +18 lines, -51 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yoyo Zhou
erg: apparently PrerenderManager shutdown can depend on ExtensionEventRouter, so I added a dependency there so ...
8 years, 9 months ago (2012-03-06 04:45:41 UTC) #1
Yoyo Zhou
Hold off on this review -- it's still failing on trybots because PrerenderManager isn't doing ...
8 years, 9 months ago (2012-03-06 05:55:32 UTC) #2
Yoyo Zhou
After crrev.com/125263 , this is now ready for review.
8 years, 9 months ago (2012-03-08 01:12:10 UTC) #3
Elliot Glaysher
8 years, 9 months ago (2012-03-08 22:17:19 UTC) #4
On 2012/03/08 01:12:10, Yoyo Zhou wrote:
> After crrev.com/125263 , this is now ready for review.

rubberstamp lgtm if the change to prerender manager is all that changed.

Powered by Google App Engine
This is Rietveld 408576698