Issue 9609018: Prevent NaCl proxy from closing the handle by bumping the ref count.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9609018: Prevent NaCl proxy from closing the handle by bumping the ref count. (Closed)

Created:
8 years, 9 months ago by nfullagar

Modified:
8 years, 9 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Prevent NaCl proxy from closing the handle by bumping the ref count. It fixes a double close bug but also introduces a small memory leak. BUG=https://chromiumcodereview.appspot.com/9610008 TEST=Bastion Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125086

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

LGTM if a hack is needed for m18 to make Bastion work. I don't have ...

8 years, 9 months ago (2012-03-06 02:03:57 UTC) #2

nfullagar

8 years, 9 months ago (2012-03-06 03:02:43 UTC) #3

On 2012/03/06 02:03:57, apatrick_chromium wrote:
> LGTM if a hack is needed for m18 to make Bastion work. I don't have owners for
> this.

Committed revision 125086.

Expand Messages | Collapse Messages