Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc

Issue 9609018: Prevent NaCl proxy from closing the handle by bumping the ref count. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc
===================================================================
--- ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc (revision 125068)
+++ ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc (working copy)
@@ -387,7 +387,9 @@
GetTransferBuffer(resource_id, id, &native_handle, &native_size);
desc_wrapper.reset(factory.ImportShmHandle(
(NaClHandle)native_handle, native_size));
- *shm_desc = desc_wrapper->desc();
+ // todo(nfullagar): Dup the handle instead of leak caused by bumping the ref.
+ // bug: https://chromiumcodereview.appspot.com/9610008
+ *shm_desc = NaClDescRef(desc_wrapper->desc());
*shm_size = native_size;
rpc->result = NACL_SRPC_RESULT_OK;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698