Issue 9608006: Add kAbortIncrementalMarkingMask flag for GC.

Issue 9608006: Add kAbortIncrementalMarkingMask flag for GC. (Closed)

Created:
8 years, 9 months ago by Michael Starzinger

Modified:
8 years, 9 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add kAbortIncrementalMarkingMask flag for GC. This adds an additional flag to control whether incremental marking should be aborted when requesting a GC, providing a finer granularity between kNoGCFlags and kMakeHeapIterableMask. R=ulan@chromium.org BUG=v8:1608 Committed: https://code.google.com/p/v8/source/detail?r=10961

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments by Ulan Degenbaev. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -34 lines)			Patch
M	src/heap.h	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/heap.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mark-compact.h	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	src/mark-compact.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mark-compact-inl.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/runtime.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View		7 chunks	+8 lines, -11 lines	0 comments	Download
M	test/cctest/test-deoptimization.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM. https://chromiumcodereview.appspot.com/9608006/diff/1/src/heap.h File src/heap.h (right): https://chromiumcodereview.appspot.com/9608006/diff/1/src/heap.h#newcode1046 src/heap.h:1046: static const int kAbortIncrementalMarkingMask = 4; Consider these ...

8 years, 9 months ago (2012-03-07 17:22:25 UTC) #2

Michael Starzinger

8 years, 9 months ago (2012-03-07 17:50:38 UTC) #3

Added new patch set.

https://chromiumcodereview.appspot.com/9608006/diff/1/src/heap.h
File src/heap.h (right):

https://chromiumcodereview.appspot.com/9608006/diff/1/src/heap.h#newcode1046
src/heap.h:1046: static const int kAbortIncrementalMarkingMask = 4;
On 2012/03/07 17:22:26, ulan wrote:
> Consider these flags:
> static const int kSweepPreciselyMask = 1;
> static const int kMakeHeapIterableMask = kSweepPreciselyMask |
> kAbortIncrementalMarkingMask;

Done.

https://chromiumcodereview.appspot.com/9608006/diff/1/src/mark-compact-inl.h
File src/mark-compact-inl.h (right):

https://chromiumcodereview.appspot.com/9608006/diff/1/src/mark-compact-inl.h#...
src/mark-compact-inl.h:52: Heap::kMakeHeapIterableMask)) != 0);
On 2012/03/07 17:22:26, ulan wrote:
> If kMakeHeapIterableMask implies abort_incremental_marking_, wouldn't it be
> cleaner to have 
> (kMakeHeapIterableMask & kAbortIncrementalMarkingMask) ==
> kAbortIncrementalMarkingMask ?

Done.

Expand Messages | Collapse Messages