test/cctest/test-deoptimization.cc - Issue 9608006: Add kAbortIncrementalMarkingMask flag for GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-deoptimization.cc

Issue 9608006: Add kAbortIncrementalMarkingMask flag for GC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments by Ulan Degenbaev. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-deoptimization.cc

diff --git a/test/cctest/test-deoptimization.cc b/test/cctest/test-deoptimization.cc

index ee57d65b2425857a43b47ec5b6c095fd694c0233..c52c5788dbce107e3db13e444bac44af56cd9c1e 100644

--- a/test/cctest/test-deoptimization.cc

+++ b/test/cctest/test-deoptimization.cc

@@ -100,8 +100,7 @@ class AllowNativesSyntaxNoInlining {

// Abort any ongoing incremental marking to make sure that all weak global

// handle callbacks are processed.

static void NonIncrementalGC() {

- // TODO(1608): This should use kAbortIncrementalMarking.

- HEAP->CollectAllGarbage(i::Heap::kMakeHeapIterableMask);

+ HEAP->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);

}

« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »