tools/testing/dart/test_runner.dart - Issue 9601023: Fix for webdriver_test_setup in Windows, and don't force close of the browsers if we're not running…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9601023: Fix for webdriver_test_setup in Windows, and don't force close of the browsers if we're not running… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_runner.dart

===================================================================

--- tools/testing/dart/test_runner.dart (revision 4980)

+++ tools/testing/dart/test_runner.dart (working copy)

@@ -905,7 +905,7 @@

* and notify our progress indicator that we are done.

void _cleanupAndMarkDone() {

- if (browserUsed != '') {

+ if (browserUsed != '' && _progress is BuildbotProgressIndicator) {

killZombieBrowsers();

if (_seleniumServer != null) {

_seleniumServer.kill();

« no previous file with comments | « no previous file | tools/testing/webdriver_test_setup.py » ('j') | no next file with comments »