Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 9601023: Fix for webdriver_test_setup in Windows, and don't force close of the browsers if we're not running… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/testing/webdriver_test_setup.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 887 matching lines...) Expand 10 before | Expand all | Expand 10 after
898 }; 898 };
899 } 899 }
900 } 900 }
901 } 901 }
902 902
903 /** 903 /**
904 * Perform any cleanup needed once all tests in a TestSuite have completed 904 * Perform any cleanup needed once all tests in a TestSuite have completed
905 * and notify our progress indicator that we are done. 905 * and notify our progress indicator that we are done.
906 */ 906 */
907 void _cleanupAndMarkDone() { 907 void _cleanupAndMarkDone() {
908 if (browserUsed != '') { 908 if (browserUsed != '' && _progress is BuildbotProgressIndicator) {
909 killZombieBrowsers(); 909 killZombieBrowsers();
910 if (_seleniumServer != null) { 910 if (_seleniumServer != null) {
911 _seleniumServer.kill(); 911 _seleniumServer.kill();
912 } 912 }
913 } else { 913 } else {
914 _progress.allDone(); 914 _progress.allDone();
915 } 915 }
916 } 916 }
917 917
918 void _checkDone() { 918 void _checkDone() {
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1126 // the developer doesn't waste his or her time trying to fix a bunch of 1126 // the developer doesn't waste his or her time trying to fix a bunch of
1127 // tests that appear to be broken but were actually just flakes that 1127 // tests that appear to be broken but were actually just flakes that
1128 // didn't get retried because there had already been one failure. 1128 // didn't get retried because there had already been one failure.
1129 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests; 1129 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
1130 new RunningProcess(test, allowRetry, this).start(); 1130 new RunningProcess(test, allowRetry, this).start();
1131 } 1131 }
1132 _numProcesses++; 1132 _numProcesses++;
1133 } 1133 }
1134 } 1134 }
1135 } 1135 }
OLDNEW
« no previous file with comments | « no previous file | tools/testing/webdriver_test_setup.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698