Add Password Autofill Manager to New Autofill

chrome/browser/autofill/autofill_external_delegate.h

Index: chrome/browser/autofill/autofill_external_delegate.h
diff --git a/chrome/browser/autofill/autofill_external_delegate.h b/chrome/browser/autofill/autofill_external_delegate.h
index b3413045783364221bb638a2667de391959e6d68..47140d1ab61841a5292d8dad70c29f420d09aa35 100644
--- a/chrome/browser/autofill/autofill_external_delegate.h
+++ b/chrome/browser/autofill/autofill_external_delegate.h
@@ -10,8 +10,10 @@
 
 #include "base/compiler_specific.h"
 #include "base/string16.h"
+#include "chrome/browser/autofill/password_autofill_manager.h"
 #include "webkit/forms/form_data.h"
 #include "webkit/forms/form_field.h"
+#include "webkit/forms/password_form_dom_manager.h"
 
 class AutofillManager;
 class TabContentsWrapper;
@@ -57,6 +59,12 @@ class AutofillExternalDelegate {
       const std::vector<string16>& autofill_icons,
       const std::vector<int>& autofill_unique_ids);
 
+  // Set the bounds of the Autofill element being worked with.
+  virtual void SetBounds(const gfx::Rect& bounds) = 0;

[Ilya Sherman, 2012/03/22 01:20:06]

nit: Perhaps "OnSetBounds()" for consistency with the other methods in this
class?

[csharp, 2012/03/23 14:31:49]

Moved this to be a protected method since I don't need it to be public anymore
so I'll leave the name the same (since it doesn't get called as a result of an
IPC let all the other On* functions)

+
+  // Show password suggestions in the popup.
+  void ShowPasswordSuggestions(const std::vector<string16>& suggestions);

[Ilya Sherman, 2012/03/22 01:20:06]

nit: Perhaps "OnShowPasswordSuggestions()" for consistency with the other
methods in this class?

[Ilya Sherman, 2012/03/22 01:20:06]

nit: Why does OnQuery() include the desired bounds, whereas
ShowPasswordSuggestions() does not?

[csharp, 2012/03/23 14:31:49]

Fixed.

+
   // Inform the delegate that the text field editing has ended, this is
   // used to help record the metrics of when a new popup is shown.
   void DidEndTextFieldEditing();
@@ -72,6 +80,15 @@ class AutofillExternalDelegate {
   // Hide the Autofill poup.
   virtual void HideAutofillPopup();
 
+  // Returns the delegate to its starting state by removing any page specific
+  // values or settings.
+  void Reset();
+
+  // Inform the Password Manager of a filled form.
+  void AddPasswordFormMapping(
+      const webkit::forms::FormField& form,
+      const webkit::forms::PasswordFormFillData& fill_data);
+
   // Platforms that wish to implement an external Autofill delegate
   // MUST implement this.  The 1st arg is the tab contents that owns
   // this delegate; the second is the Autofill manager owned by the
@@ -111,6 +128,9 @@ class AutofillExternalDelegate {
   TabContentsWrapper* tab_contents_wrapper_;  // weak; owns me.
   AutofillManager* autofill_manager_;  // weak.
 
+  // Password Autofill manager, handles all password-related Autofilling.
+  PasswordAutofillManager password_autofill_manager_;
+
   // The ID of the last request sent for form field Autofill.  Used to ignore
   // out of date responses.
   int autofill_query_id_;
@@ -132,6 +152,12 @@ class AutofillExternalDelegate {
   // The menu index of the "Autofill options..." menu item.
   int suggestions_options_index_;
 
+  // The value to give as the unique ids for all warnings.
+  const int kWarningIds = -1;
+
+  // The value to give as the unique ids for all password entries.
+  const int kPasswordEntryIds = -2;
+
   DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
 };