Add Password Autofill Manager to New Autofill

chrome/browser/autofill/autofill_external_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 #pragma once
 
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/string16.h"
+#include "chrome/browser/autofill/password_autofill_manager.h"
 #include "webkit/forms/form_data.h"
 #include "webkit/forms/form_field.h"
+#include "webkit/forms/password_form_dom_manager.h"
 
 class AutofillManager;
 class TabContentsWrapper;
 
 namespace gfx {
 class Rect;
 }
 
 // TODO(csharp): A lot of the logic in this class is copied from autofillagent.
 // Once Autofill is moved out of WebKit this class should be the only home for
@@ skipping 25 matching lines @@
 
   // Records query results and correctly formats them before sending them off
   // to be displayed.  Called when an Autofill query result is available.
   virtual void OnSuggestionsReturned(
       int query_id,
       const std::vector<string16>& autofill_values,
       const std::vector<string16>& autofill_labels,
       const std::vector<string16>& autofill_icons,
       const std::vector<int>& autofill_unique_ids);
 
+  // Set the bounds of the Autofill element being worked with.
+  virtual void SetBounds(const gfx::Rect& bounds) = 0;

[Ilya Sherman, 2012/03/22 01:20:06]

nit: Perhaps "OnSetBounds()" for consistency with the other methods in this
class?

[csharp, 2012/03/23 14:31:49]

Moved this to be a protected method since I don't need it to be public anymore
so I'll leave the name the same (since it doesn't get called as a result of an
IPC let all the other On* functions)

+
+  // Show password suggestions in the popup.
+  void ShowPasswordSuggestions(const std::vector<string16>& suggestions);

[Ilya Sherman, 2012/03/22 01:20:06]

nit: Perhaps "OnShowPasswordSuggestions()" for consistency with the other
methods in this class?

[Ilya Sherman, 2012/03/22 01:20:06]

nit: Why does OnQuery() include the desired bounds, whereas
ShowPasswordSuggestions() does not?

[csharp, 2012/03/23 14:31:49]

Fixed.

+
   // Inform the delegate that the text field editing has ended, this is
   // used to help record the metrics of when a new popup is shown.
   void DidEndTextFieldEditing();
 
   // Inform the delegate that an autofill suggestion have been chosen.
   void DidAcceptAutofillSuggestions(const string16& value,
                                     int unique_id,
                                     unsigned index);
 
   // Informs the delegate that the Autofill previewed form should be cleared.
   virtual void ClearPreviewedForm();
 
   // Hide the Autofill poup.
   virtual void HideAutofillPopup();
 
+  // Returns the delegate to its starting state by removing any page specific
+  // values or settings.
+  void Reset();
+
+  // Inform the Password Manager of a filled form.
+  void AddPasswordFormMapping(
+      const webkit::forms::FormField& form,
+      const webkit::forms::PasswordFormFillData& fill_data);
+
   // Platforms that wish to implement an external Autofill delegate
   // MUST implement this.  The 1st arg is the tab contents that owns
   // this delegate; the second is the Autofill manager owned by the
   // tab contents.
   static AutofillExternalDelegate* Create(TabContentsWrapper*,
                                           AutofillManager*);
  protected:
   explicit AutofillExternalDelegate(TabContentsWrapper* tab_contents_wrapper,
                                     AutofillManager* autofill_manager);
 
@@ skipping 19 matching lines @@
  private:
   // Fills the form with the Autofill data corresponding to |unique_id|.
   // If |is_preview| is true then this is just a preview to show the user what
   // would be selected and if |is_preview| is false then the user has selected
   // this data.
   void FillAutofillFormData(int unique_id, bool is_preview);
 
   TabContentsWrapper* tab_contents_wrapper_;  // weak; owns me.
   AutofillManager* autofill_manager_;  // weak.
 
+  // Password Autofill manager, handles all password-related Autofilling.
+  PasswordAutofillManager password_autofill_manager_;
+
   // The ID of the last request sent for form field Autofill.  Used to ignore
   // out of date responses.
   int autofill_query_id_;
 
   // The current form and field selected by Autofill.
   webkit::forms::FormData autofill_query_form_;
   webkit::forms::FormField autofill_query_field_;
 
   // Should we display a warning if Autofill is disabled?
   bool display_warning_if_disabled_;
 
   // Have we already shown Autofill suggestions for the field the user is
   // currently editing?  Used to keep track of state for metrics logging.
   bool has_shown_autofill_popup_for_current_edit_;
 
   // The menu index of the "Clear" menu item.
   int suggestions_clear_index_;
 
   // The menu index of the "Autofill options..." menu item.
   int suggestions_options_index_;
 
+  // The value to give as the unique ids for all warnings.
+  const int kWarningIds = -1;
+
+  // The value to give as the unique ids for all password entries.
+  const int kPasswordEntryIds = -2;
+
   DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_