Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 9599025: Merge 109060 - RenderLayer ClipRect not accounting for transforms (Closed)

Created:
8 years, 6 months ago by shawnsingh
Modified:
8 years, 6 months ago
Reviewers:
shawnsingh
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 109060 - RenderLayer ClipRect not accounting for transforms https://bugs.webkit.org/show_bug.cgi?id=76486 Reviewed by Simon Fraser. Source/WebCore: Test: compositing/layer-creation/overlap-transformed-and-clipped.html This patch changes calculateClipRects() so that the clipRect offset is allowed to be converted across layers with transforms. This is necessary because the RenderLayerCompositor needs clipRects in document space, rather than with respect to some local clipping layer. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): * rendering/RenderObject.cpp: (WebCore::RenderObject::localToContainerPoint): (WebCore): * rendering/RenderObject.h: (RenderObject): LayoutTests: * compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added. * compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added. * compositing/layer-creation/overlap-transformed-and-clipped.html: Added. TBR=shawnsingh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=109794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, --2 lines) Patch
A + LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/WebCore/rendering/RenderObject.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
shawnsingh
8 years, 6 months ago (2012-03-05 21:43:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698