Add a first class GrowableObjectArray type in the VM and use it internally in the VM at all spots w…

vm/raw_object.h

Index: vm/raw_object.h
===================================================================
--- vm/raw_object.h	(revision 4983)
+++ vm/raw_object.h	(working copy)
@@ -61,6 +61,7 @@
     V(Bool)                                                                    \
     V(Array)                                                                   \
       V(ImmutableArray)                                                        \
+    V(GrowableObjectArray)                                                     \
     V(ByteArray)                                                               \
       V(InternalByteArray)                                                     \
       V(ExternalByteArray)                                                     \
@@ -996,6 +997,24 @@
 };
 
 
+class RawGrowableObjectArray : public RawInstance {
+  RAW_HEAP_OBJECT_IMPLEMENTATION(GrowableObjectArray);
+
+  RawObject** from() {
+    return reinterpret_cast<RawObject**>(&ptr()->data_);
+  }
+  RawArray* data_;
+  RawObject** to() {
+    return reinterpret_cast<RawObject**>(&ptr()->data_);
+  }
+
+  intptr_t capacity_;

[cshapiro, 2012/03/06 00:56:31]

I am not sure why we need a separate capacity_ member when we have the array
length in data_.  Is there ever a situation where these values are not equal?

Presumably, these size fields are Smi instances.  I have been lead to believe
that we should scan those like other reference values.

[siva, 2012/03/06 23:32:33]

Removed the capacity_ field and made length_ a Smi.

On 2012/03/06 00:56:31, cshapiro wrote:

+  intptr_t length_;
+
+  friend class SnapshotReader;
+};
+
+
 class RawByteArray : public RawInstance {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ByteArray);