Add a first class GrowableObjectArray type in the VM and use it internally in the VM at all spots w…

vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/token.h"
@@ skipping 43 matching lines @@
     V(String)                                                                  \
       V(OneByteString)                                                         \
       V(TwoByteString)                                                         \
       V(FourByteString)                                                        \
       V(ExternalOneByteString)                                                 \
       V(ExternalTwoByteString)                                                 \
       V(ExternalFourByteString)                                                \
     V(Bool)                                                                    \
     V(Array)                                                                   \
       V(ImmutableArray)                                                        \
+    V(GrowableObjectArray)                                                     \
     V(ByteArray)                                                               \
       V(InternalByteArray)                                                     \
       V(ExternalByteArray)                                                     \
     V(Closure)                                                                 \
     V(Stacktrace)                                                              \
     V(JSRegExp)                                                                \
     V(ICData)                                                                  \
 
 #define CLASS_LIST(V)                                                          \
   V(Object)                                                                    \
@@ skipping 915 matching lines @@
 };
 
 
 class RawImmutableArray : public RawArray {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ImmutableArray);
 
   friend class SnapshotReader;
 };
 
 
+class RawGrowableObjectArray : public RawInstance {
+  RAW_HEAP_OBJECT_IMPLEMENTATION(GrowableObjectArray);
+
+  RawObject** from() {
+    return reinterpret_cast<RawObject**>(&ptr()->data_);
+  }
+  RawArray* data_;
+  RawObject** to() {
+    return reinterpret_cast<RawObject**>(&ptr()->data_);
+  }
+
+  intptr_t capacity_;

[cshapiro, 2012/03/06 00:56:31]

I am not sure why we need a separate capacity_ member when we have the array
length in data_.  Is there ever a situation where these values are not equal?

Presumably, these size fields are Smi instances.  I have been lead to believe
that we should scan those like other reference values.

[siva, 2012/03/06 23:32:33]

Removed the capacity_ field and made length_ a Smi.

On 2012/03/06 00:56:31, cshapiro wrote:

+  intptr_t length_;
+
+  friend class SnapshotReader;
+};
+
+
 class RawByteArray : public RawInstance {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ByteArray);
 
  protected:
   RawObject** from() { return reinterpret_cast<RawObject**>(&ptr()->length_); }
   RawSmi* length_;
   RawObject** to() { return reinterpret_cast<RawObject**>(&ptr()->length_); }
 };
 
 
@@ skipping 111 matching lines @@
   RawString* target_name_;  // Name of target function.
   RawArray* ic_data_;  // Contains test classes and target function.
   intptr_t id_;  // Parser node id corresponding to this IC.
   intptr_t num_args_tested_;  // Number of arguments tested in IC.
 };
 
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_