Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5713)

Unified Diff: chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc

Issue 9592026: Create meta table atomically. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc
diff --git a/chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc b/chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc
index bbeb040fd4b98dbecf150b6f75d70361ce1d6af5..6c278116364459a43348e434e0e0076215fb576e 100644
--- a/chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc
+++ b/chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc
@@ -160,9 +160,8 @@ TEST_F(SQLitePersistentCookieStoreTest, TestInvalidMetaTableRecovery) {
sql::Connection db;
ASSERT_TRUE(db.Open(temp_dir_.path().Append(chrome::kCookieFilename)));
sql::MetaTable meta_table_;
- meta_table_.Init(&db, 0, 0);
- meta_table_.SetVersionNumber(0);
- meta_table_.SetCompatibleVersionNumber(0);
+ meta_table_.Init(&db, 1, 1);
+ ASSERT_TRUE(db.Execute("DELETE FROM meta"));
erikwright (departed) 2012/03/07 14:57:34 I'd prefer if MetaTable either exposed a 'Delete'
Scott Hess - ex-Googler 2012/03/07 15:24:27 I would not be happy exposing such information as
db.Close();
}
« no previous file with comments | « chrome/browser/history/history_database.cc ('k') | sql/meta_table.h » ('j') | sql/meta_table.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698