Create meta table atomically.

chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 142 matching lines @@
   ASSERT_STREQ("B", cookies[0]->Value().c_str());
   DestroyStore();
   STLDeleteContainerPointers(cookies.begin(), cookies.end());
   cookies.clear();
 
   // Now corrupt the meta table.
   {
     sql::Connection db;
     ASSERT_TRUE(db.Open(temp_dir_.path().Append(chrome::kCookieFilename)));
     sql::MetaTable meta_table_;
-    meta_table_.Init(&db, 0, 0);
-    meta_table_.SetVersionNumber(0);
-    meta_table_.SetCompatibleVersionNumber(0);
+    meta_table_.Init(&db, 1, 1);
+    ASSERT_TRUE(db.Execute("DELETE FROM meta"));

[erikwright (departed), 2012/03/07 14:57:34]

I'd prefer if MetaTable either exposed a 'Delete' method or exposed a kTableName
static member.

[Scott Hess - ex-Googler, 2012/03/07 15:24:27]

I would not be happy exposing such information as part of a non-testing API. 
Exposing it as part of a testing API would effectively mean friending this test,
which to me feels more broken than just going direct.  I think the main goal
should be that this test should break if someone changes the internals of how
sql::MetaTable works, which I think happens here, which will happen, here.

     db.Close();
   }
 
   // Upon loading, the database should be reset to a good, blank state.
   CreateAndLoad(false, &cookies);
   ASSERT_EQ(0U, cookies.size());
 
   // Verify that, after, recovery, the database persists properly.
   AddCookie("X", "Y", "http://foo.bar", "/", base::Time::Now());
   DestroyStore();
@@ skipping 270 matching lines @@
 
   EXPECT_FALSE(cookie_map["session-noexpires"]->DoesExpire());
   EXPECT_FALSE(cookie_map["session-noexpires"]->IsPersistent());
 
   EXPECT_TRUE(cookie_map["persistent"]->DoesExpire());
   EXPECT_TRUE(cookie_map["persistent"]->IsPersistent());
 
   STLDeleteContainerPointers(cookies.begin(), cookies.end());
   cookies.clear();
 }