Issue 9586023: Fix memory failures in PasswordManager tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9586023: Fix memory failures in PasswordManager tests (Closed)

Created:
8 years, 9 months ago by Ilya Sherman

Modified:
8 years, 9 months ago

Reviewers:
Mike Mammarella, tim (not reviewing), dhollowa

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix memory failures in PasswordManager tests BUG=none TEST=happy heapcheck bots TBR=mdm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124778

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	chrome/browser/password_manager/password_manager.cc	View		3 chunks	+4 lines, -4 lines	1 comment	Download
	M	chrome/browser/password_manager/password_manager_unittest.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dhollowa

Rubber stamp LGTM for memory bots. Please TBR proper owners. Thanks. https://chromiumcodereview.appspot.com/9586023/diff/1/chrome/browser/password_manager/password_manager.cc File chrome/browser/password_manager/password_manager.cc (right): ...

8 years, 9 months ago (2012-03-02 23:49:35 UTC) #1

On 2012/03/02 23:52:15, Ilya Sherman wrote:

LGTM

Expand Messages | Collapse Messages