Fix memory failures in PasswordManager tests

chrome/browser/password_manager/password_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager.h"
 
 #include "base/threading/platform_thread.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager_delegate.h"
@@ skipping 64 matching lines @@
 }
 
 void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
   if (!IsEnabled())
     return;
 
   // No password to save? Then don't.
   if (form.password_value.empty())
     return;
 
-  PasswordFormManager* manager = NULL;
+  scoped_ptr<PasswordFormManager> manager;
   for (ScopedVector<PasswordFormManager>::iterator iter =
            pending_login_managers_.begin();
        iter != pending_login_managers_.end(); ++iter) {
     if ((*iter)->DoesManage(form)) {
-      manager = *iter;
+      manager.reset(*iter);

[dhollowa, 2012/03/02 23:49:35]

A comment here would be nice.  "Transfer ownership" or something.

       pending_login_managers_.weak_erase(iter);
       break;
     }
   }
   // If we didn't find a manager, this means a form was submitted without
   // first loading the page containing the form. Don't offer to save
   // passwords in this case.
-  if (!manager)
+  if (!manager.get())
     return;
 
   // If we found a manager but it didn't finish matching yet, the user has
   // tried to submit credentials before we had time to even find matching
   // results for the given form and autofill. If this is the case, we just
   // give up.
   if (!manager->HasCompletedMatching())
     return;
 
   // Also get out of here if the user told us to 'never remember' passwords for
   // this form.
   if (manager->IsBlacklisted())
     return;
 
   PasswordForm provisionally_saved_form(form);
   provisionally_saved_form.ssl_valid = form.origin.SchemeIsSecure() &&
       !delegate_->DidLastPageLoadEncounterSSLErrors();
   provisionally_saved_form.preferred = true;
   manager->ProvisionallySave(provisionally_saved_form);
-  provisional_save_manager_.reset(manager);
+  provisional_save_manager_.swap(manager);
 }
 
 void PasswordManager::SetObserver(LoginModelObserver* observer) {
   observer_ = observer;
 }
 
 void PasswordManager::DidStopLoading() {
   if (!provisional_save_manager_.get())
     return;
 
@@ skipping 103 matching lines @@
         observer_->OnAutofillDataAvailable(preferred_match.username_value,
                                            preferred_match.password_value);
       }
   }
 }
 
 bool PasswordManager::IsEnabled() const {
   const Profile* profile = delegate_->GetProfileForPasswordManager();
   return profile && !profile->IsOffTheRecord() && *password_manager_enabled_;
 }