Issue 9586018: Add support for multiple icon sizes for Mac platform apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9586018: Add support for multiple icon sizes for Mac platform apps (Closed)

Created:
8 years, 9 months ago by sail

Modified:
8 years, 9 months ago

Reviewers:

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, Aaron Boodman, mihaip+watch_chromium.org, estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for multiple icon sizes for Mac platform apps This is the combined version of the following CLs: http://codereview.chromium.org/9428025/ http://codereview.chromium.org/9500007/ http://codereview.chromium.org/9535002/ BUG=112651 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124875

Patch Set 1 #

Patch Set 2 : fix build #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+541 lines, -296 lines)			Patch
M	chrome/browser/background/background_application_list_model.cc	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/app_shortcut_manager.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/app_shortcut_manager.cc	View		5 chunks	+52 lines, -32 lines	0 comments	Download
M	chrome/browser/extensions/extension_icon_manager.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_icon_manager.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_icon_manager_unittest.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_helper.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tab_helper.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_uninstall_dialog.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_uninstall_dialog.cc	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_web_ui.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/image_loading_tracker.h	View		5 chunks	+45 lines, -15 lines	0 comments	Download
M	chrome/browser/extensions/image_loading_tracker.cc	View		4 chunks	+110 lines, -36 lines	0 comments	Download
M	chrome/browser/extensions/image_loading_tracker_unittest.cc	View		8 chunks	+51 lines, -12 lines	0 comments	Download
M	chrome/browser/shell_integration.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/shell_integration_linux.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/browser_action_button.mm	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm	View		2 chunks	+11 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/page_action_decoration.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm	View		2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc	View	1	3 chunks	+14 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc	View		2 chunks	+12 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/aura/app_list/extension_app_item.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/aura/app_list/extension_app_item.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/aura/launcher/chrome_launcher_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/aura/launcher/chrome_launcher_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/aura/launcher/launcher_icon_loader.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/aura/launcher/launcher_icon_loader.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/create_application_shortcut_view.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/create_application_shortcut_view.cc	View	1	4 chunks	+14 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/extension_infobar.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/extension_infobar.cc	View		2 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/page_action_image_view.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/page_action_image_view.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/web_applications/web_app_ui.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_icon_source.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_icon_source.cc	View		3 chunks	+12 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/favicon_webui_handler.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_mac.mm	View		2 chunks	+59 lines, -17 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_mac_unittest.mm	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/gfx/image/image.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/image/image.cc	View		1 chunk	+1 line, -1 line	0 comments	Download