Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1741)

Unified Diff: chrome/browser/web_applications/web_app_mac_unittest.mm

Issue 9586018: Add support for multiple icon sizes for Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix build Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_applications/web_app_mac.mm ('k') | ui/gfx/image/image.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app_mac_unittest.mm
diff --git a/chrome/browser/web_applications/web_app_mac_unittest.mm b/chrome/browser/web_applications/web_app_mac_unittest.mm
index 6d95261679e5511a294dad81f820a811df924a7a..bfa5c84806a7f918f11adbe68639a61b31cd861d 100644
--- a/chrome/browser/web_applications/web_app_mac_unittest.mm
+++ b/chrome/browser/web_applications/web_app_mac_unittest.mm
@@ -89,8 +89,8 @@ TEST(WebAppShortcutCreatorTest, UpdateIcon) {
FilePath dst_path = scoped_temp_dir.path();
ShellIntegration::ShortcutInfo info = GetShortcutInfo();
- info.favicon = *ui::ResourceBundle::GetSharedInstance().GetImageNamed(
- IDR_PRODUCT_LOGO_32).ToSkBitmap();
+ info.favicon = ui::ResourceBundle::GetSharedInstance().GetImageNamed(
+ IDR_PRODUCT_LOGO_32);
WebAppShortcutCreatorMock shortcut_creator(info);
shortcut_creator.UpdateIcon(dst_path);
@@ -100,8 +100,8 @@ TEST(WebAppShortcutCreatorTest, UpdateIcon) {
scoped_nsobject<NSImage> image([[NSImage alloc] initWithContentsOfFile:
base::mac::FilePathToNSString(icon_path)]);
EXPECT_TRUE(image);
- EXPECT_EQ(info.favicon.width(), [image size].width);
- EXPECT_EQ(info.favicon.height(), [image size].height);
+ EXPECT_EQ(info.favicon.ToSkBitmap()->width(), [image size].width);
+ EXPECT_EQ(info.favicon.ToSkBitmap()->height(), [image size].height);
}
} // namespace web_app
« no previous file with comments | « chrome/browser/web_applications/web_app_mac.mm ('k') | ui/gfx/image/image.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698