Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 9582032: [uber page] Integrate history into uber page. (Closed)

Created:
8 years, 9 months ago by csilv
Modified:
8 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Patrick Dubroy, arv (Not doing code reviews)
Visibility:
Public.

Description

[uber page] Integrate history into uber page. Insert the history page into uber, redirect history menu command and urls to the uber page. Also included in this CL: * Use localized strings for frame URLs in uber.html. * Turn off uppercase on page titles per latest mocks. * Re-order page titles per latest mocks. Reflected order in code for readability. BUG=116447 TEST=Exercise history in uber page, invoking from menu commands. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124872

Patch Set 1 : #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : code review updates #

Patch Set 4 : fix history tests. #

Patch Set 5 : final tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -30 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/history/history.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/history/history.js View 1 2 3 4 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/uber/uber.html View 1 2 1 chunk +12 lines, -9 lines 0 comments Download
M chrome/browser/resources/uber/uber_frame.css View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/uber/uber_frame.html View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 2 4 chunks +21 lines, -7 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/reliability/automated_ui_test_test.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
csilv
+estade for review https://chromiumcodereview.appspot.com/9582032/diff/2003/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://chromiumcodereview.appspot.com/9582032/diff/2003/chrome/browser/browser_about_handler.cc#newcode137 chrome/browser/browser_about_handler.cc:137: host = chrome::kChromeUIHistoryFrameHost; This isn't ideal... ...
8 years, 9 months ago (2012-03-02 23:05:54 UTC) #1
Evan Stade
https://chromiumcodereview.appspot.com/9582032/diff/2003/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://chromiumcodereview.appspot.com/9582032/diff/2003/chrome/browser/browser_about_handler.cc#newcode137 chrome/browser/browser_about_handler.cc:137: host = chrome::kChromeUIHistoryFrameHost; On 2012/03/02 23:05:54, csilv wrote: > ...
8 years, 9 months ago (2012-03-02 23:29:54 UTC) #2
csilv
https://chromiumcodereview.appspot.com/9582032/diff/2003/chrome/browser/resources/uber/uber.html File chrome/browser/resources/uber/uber.html (right): https://chromiumcodereview.appspot.com/9582032/diff/2003/chrome/browser/resources/uber/uber.html#newcode30 chrome/browser/resources/uber/uber.html:30: i18n-values="id:settingsHost;data-url:settingsFrameURL;" On 2012/03/02 23:29:54, Evan Stade wrote: > you ...
8 years, 9 months ago (2012-03-02 23:48:09 UTC) #3
Evan Stade
8 years, 9 months ago (2012-03-02 23:49:47 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698