Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: chrome/browser/ui/browser_navigator_browsertest.cc

Issue 9582032: [uber page] Integrate history into uber page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: final tweaks Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_navigator_browsertest.h" 5 #include "chrome/browser/ui/browser_navigator_browsertest.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/autocomplete/autocomplete_edit.h" 9 #include "chrome/browser/autocomplete/autocomplete_edit.h"
10 #include "chrome/browser/prefs/incognito_mode_prefs.h" 10 #include "chrome/browser/prefs/incognito_mode_prefs.h"
(...skipping 1224 matching lines...) Expand 10 before | Expand all | Expand 10 after
1235 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, 1235 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest,
1236 NavigateFromDefaultToHistoryInSameTab) { 1236 NavigateFromDefaultToHistoryInSameTab) {
1237 { 1237 {
1238 ui_test_utils::WindowedNotificationObserver observer( 1238 ui_test_utils::WindowedNotificationObserver observer(
1239 content::NOTIFICATION_LOAD_STOP, 1239 content::NOTIFICATION_LOAD_STOP,
1240 content::NotificationService::AllSources()); 1240 content::NotificationService::AllSources());
1241 browser()->ShowHistoryTab(); 1241 browser()->ShowHistoryTab();
1242 observer.Wait(); 1242 observer.Wait();
1243 } 1243 }
1244 EXPECT_EQ(1, browser()->tab_count()); 1244 EXPECT_EQ(1, browser()->tab_count());
1245 EXPECT_EQ(GURL(chrome::kChromeUIHistoryURL), 1245 // TODO(csilv): Update this for uber page. http://crbug.com/111579.
1246 EXPECT_EQ(GURL(chrome::kChromeUIHistoryFrameURL),
1246 browser()->GetSelectedWebContents()->GetURL()); 1247 browser()->GetSelectedWebContents()->GetURL());
1247 } 1248 }
1248 1249
1249 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, 1250 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest,
1250 NavigateFromDefaultToBookmarksInSameTab) { 1251 NavigateFromDefaultToBookmarksInSameTab) {
1251 { 1252 {
1252 ui_test_utils::WindowedNotificationObserver observer( 1253 ui_test_utils::WindowedNotificationObserver observer(
1253 content::NOTIFICATION_LOAD_STOP, 1254 content::NOTIFICATION_LOAD_STOP,
1254 content::NotificationService::AllSources()); 1255 content::NotificationService::AllSources());
1255 browser()->OpenBookmarkManager(); 1256 browser()->OpenBookmarkManager();
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
1322 EXPECT_EQ(browser(), p2.browser); 1323 EXPECT_EQ(browser(), p2.browser);
1323 1324
1324 // We should now have two windows, the browser() provided by the framework and 1325 // We should now have two windows, the browser() provided by the framework and
1325 // the panel window we opened earlier. The tabbed browser window has 2 tabs. 1326 // the panel window we opened earlier. The tabbed browser window has 2 tabs.
1326 EXPECT_EQ(2u, BrowserList::size()); 1327 EXPECT_EQ(2u, BrowserList::size());
1327 EXPECT_EQ(2, browser()->tab_count()); 1328 EXPECT_EQ(2, browser()->tab_count());
1328 EXPECT_EQ(1, panel_browser->tab_count()); 1329 EXPECT_EQ(1, panel_browser->tab_count());
1329 } 1330 }
1330 1331
1331 } // namespace 1332 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698