Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/debugger_x64.cc

Issue 9581013: Splitting debugger breakpoints into two parts (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/debugger.h ('K') | « runtime/vm/debugger_ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_x64.cc
===================================================================
--- runtime/vm/debugger_x64.cc (revision 4881)
+++ runtime/vm/debugger_x64.cc (working copy)
@@ -28,7 +28,7 @@
}
-void Breakpoint::PatchFunctionReturn() {
+void CodeBreakpoint::PatchFunctionReturn() {
uint8_t* code = reinterpret_cast<uint8_t*>(pc_ - 13);
// movq %rbp,%rsp
ASSERT((code[0] == 0x48) && (code[1] == 0x8b) && (code[2] == 0xe5));
@@ -51,7 +51,7 @@
}
-void Breakpoint::RestoreFunctionReturn() {
+void CodeBreakpoint::RestoreFunctionReturn() {
uint8_t* code = reinterpret_cast<uint8_t*>(pc_ - 13);
ASSERT((code[0] == 0x49) && (code[1] == 0xbb));
code[0] = 0x48; // movq %rbp,%rsp
« runtime/vm/debugger.h ('K') | « runtime/vm/debugger_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698