Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/debugger_ia32.cc

Issue 9581013: Splitting debugger breakpoints into two parts (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/debugger.h ('K') | « runtime/vm/debugger_arm.cc ('k') | runtime/vm/debugger_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_ia32.cc
===================================================================
--- runtime/vm/debugger_ia32.cc (revision 4881)
+++ runtime/vm/debugger_ia32.cc (working copy)
@@ -35,7 +35,7 @@
}
-void Breakpoint::PatchFunctionReturn() {
+void CodeBreakpoint::PatchFunctionReturn() {
uint8_t* code = reinterpret_cast<uint8_t*>(pc_ - 5);
ASSERT((code[0] == 0x89) && (code[1] == 0xEC)); // mov esp,ebp
ASSERT(code[2] == 0x5D); // pop ebp
@@ -50,7 +50,7 @@
}
-void Breakpoint::RestoreFunctionReturn() {
+void CodeBreakpoint::RestoreFunctionReturn() {
uint8_t* code = reinterpret_cast<uint8_t*>(pc_ - 5);
ASSERT(code[0] == 0xE8);
code[0] = 0x89;
« runtime/vm/debugger.h ('K') | « runtime/vm/debugger_arm.cc ('k') | runtime/vm/debugger_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698