Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 9572006: Revert 124622 - Change kB to KB for consistency. (Closed)

Created:
8 years, 9 months ago by battre
Modified:
8 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Revert 124622 - Change kB to KB for consistency. Reverting as it breaks BytesFormattingTest.FormatBytes BUG=chromium-os:22812 TEST=Open task manager or downloads, and observe KB instead of kB. Review URL: https://chromiumcodereview.appspot.com/9490008 TBR=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/base/strings/ui_strings.grd View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
battre
8 years, 9 months ago (2012-03-02 10:00:12 UTC) #1
Hironori Bono
Greetings Dmitry, This is just for your information. Unfortunately, your r124622 has been reverted because ...
8 years, 9 months ago (2012-03-02 10:11:09 UTC) #2
dgozman
8 years, 9 months ago (2012-03-02 10:14:09 UTC) #3
Hello Hironori,

Sure, I will do this. Sorry for breaking tree.

Thanks,
Dmitry

On Fri, Mar 2, 2012 at 2:11 PM, <hbono@chromium.org> wrote:

> Greetings Dmitry,
>
> This is just for your information.
> Unfortunately, your r124622 has been reverted because it broke
> BytesFormattingTest.**FormatBytes on all bots as listed below.
>
> <http://build.chromium.org/p/**chromium/builders/Win7%**
>
20Tests%20%283%29/builds/3790<http://build.chromium.org/p/chromium/builders/Win7%20Tests%20%283%29/builds/3790>
> >
> <http://build.chromium.org/p/**chromium/builders/Mac10.5%**
>
20Tests%20%282%29/builds/13350<http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20%282%29/builds/13350>
> **>
> <http://build.chromium.org/p/**chromium/builders/Mac10.5%**
>
20Tests%20%282%29/builds/13350<http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20%282%29/builds/13350>
> **>
> <http://build.chromium.org/p/**chromium/builders/Linux%**
>
20Clang%20%28dbg%29/builds/**21221<http://build.chromium.org/p/chromium/builders/Linux%20Clang%20%28dbg%29/builds/21221>
> >
>
> It seems your r124622 changed resource text without rebaselining
> BytesFormattingTest.**FormatBytes and this test has been failing after
> the change.
> Would it be possible for your next change to replace 'kB' in this test
> with 'KB'
> so it does not break this test?
>
> Regards,
>
> Hironori Bono
>
>
https://chromiumcodereview.**appspot.com/9572006/<https://chromiumcodereview....
>

Powered by Google App Engine
This is Rietveld 408576698