Change kB to KB for consistency.

Change kB to KB for consistency.

BUG=chromium-os:22812
TEST=Open task manager or downloads, and observe KB instead of kB.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124947

[dgozman, 2012-02-28 14:01:37]

Hi Kathy,

May you have a look at this small change?
I hope, you are the right person to review this :)

Thanks,
Dmitry

[joshwoodward, 2012-02-28 15:14:32]

Thanks!
On Feb 28, 2012 6:01 AM, <dgozman@chromium.org> wrote:

> Reviewers: kathyw,
>
> Message:
> Hi Kathy,
>
> May you have a look at this small change?
> I hope, you are the right person to review this :)
>
> Thanks,
> Dmitry
>
> Description:
> Change kB to KB consistency.
>
> BUG=chromium-os:22812
> TEST=Open task manager or downloads, and observe KB instead of kB.
>
> Please review this at
https://chromiumcodereview.**appspot.com/9490008/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     ui/base/strings/ui_strings.grd
>
>
> Index: ui/base/strings/ui_strings.grd
> ==============================**==============================**=======
> --- ui/base/strings/ui_strings.grd      (revision 123948)
> +++ ui/base/strings/ui_strings.grd      (working copy)
> @@ -343,7 +343,7 @@
>         <ph name="QUANTITY">$1<ex>42</ex><**/ph> B
>       </message>
>       <message name="IDS_APP_KIBIBYTES" desc="Units tag indicating a
> quantity of kilobytes">
> -        <ph name="QUANTITY">$1<ex>42.0</**ex></ph> kB
> +        <ph name="QUANTITY">$1<ex>42.0</**ex></ph> KB
>       </message>
>       <message name="IDS_APP_MEBIBYTES" desc="Units tag indicating a
> quantity of megabytes">
>         <ph name="QUANTITY">$1<ex>42.0</**ex></ph> MB
> @@ -361,7 +361,7 @@
>         <ph name="QUANTITY">$1<ex>42</ex><**/ph> B/s
>       </message>
>       <message name="IDS_APP_KIBIBYTES_PER_**SECOND" desc="Units tag
> indicating a speed of kilobytes/second">
> -        <ph name="QUANTITY">$1<ex>42.0</**ex></ph> kB/s
> +        <ph name="QUANTITY">$1<ex>42.0</**ex></ph> KB/s
>       </message>
>       <message name="IDS_APP_MEBIBYTES_PER_**SECOND" desc="Units tag
> indicating a speed of megabytes/second">
>         <ph name="QUANTITY">$1<ex>42.0</**ex></ph> MB/s
>
>
>

[kathyw, 2012-02-28 16:11:01]

lgtm

By the way, this made me look up prefixes. kB is actually correct, since
prefixes for 1000 and below are lowercase, but KB looks better (next to MB et
al) and isn't incorrect.

[commit-bot: I haz the power, 2012-02-29 09:06:28]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dgozman, 2012-02-29 09:06:34]

On Tue, Feb 28, 2012 at 8:11 PM, <kathyw@chromium.org> wrote:

> lgtm
>
> By the way, this made me look up prefixes. kB is actually correct, since
> prefixes for 1000 and below are lowercase, but KB looks better (next to MB
> et
> al) and isn't incorrect.
>

And even kB (1000 bytes) is wrong, it should be kiB (1024). So, KB is not
worse :)


>
>
https://chromiumcodereview.**appspot.com/9490008/<https://chromiumcodereview....
>

[dgozman, 2012-02-29 09:08:15]

Scott, may you please approve this?

Thanks,
Dmitry

[sky, 2012-02-29 15:52:31]

LGTM

[Nico, 2012-03-02 15:48:03]

Let's not do this. 'k' lower case and 'M' upper case are the standardized
spellings: http://en.wikipedia.org/wiki/SI_prefix

[sky, 2012-03-02 16:42:56]

Windows shows KB. What does OS X show?

  -Scott

On Fri, Mar 2, 2012 at 7:48 AM,  <thakis@chromium.org> wrote:
> Let's not do this. 'k' lower case and 'M' upper case are the standardized
> spellings: http://en.wikipedia.org/wiki/SI_prefix
>
> https://chromiumcodereview.appspot.com/9490008/

[joshwoodward, 2012-03-02 16:47:24]

OS X uses KB. IMO, this is how we should go.

-Josh


On Fri, Mar 2, 2012 at 8:42 AM, Scott Violet <sky@chromium.org> wrote:

> Windows shows KB. What does OS X show?
>
>  -Scott
>
> On Fri, Mar 2, 2012 at 7:48 AM,  <thakis@chromium.org> wrote:
> > Let's not do this. 'k' lower case and 'M' upper case are the standardized
> > spellings: http://en.wikipedia.org/wiki/SI_prefix
> >
> > https://chromiumcodereview.appspot.com/9490008/
>

[glen, 2012-03-02 17:31:47]

If we were using SI units, I'd say we should use kB, but we're not. If
we're going to be wrong, we might as well not pretend to be right.


On Fri, Mar 2, 2012 at 7:48 AM, <thakis@chromium.org> wrote:

> Let's not do this. 'k' lower case and 'M' upper case are the standardized
> spellings:
http://en.wikipedia.org/wiki/**SI_prefix<http://en.wikipedia.org/wiki/SI_prefix>
>
>
https://chromiumcodereview.**appspot.com/9490008/<https://chromiumcodereview....
>

[Nico, 2012-03-02 18:04:17]

On 2012/03/02 17:31:47, glen wrote:
> If we were using SI units, I'd say we should use kB, but we're not. If
> we're going to be wrong, we might as well not pretend to be right.

Glen wins by virtue of being Glen, but "We're doing X wrong, so instead of
fixing it we might as well do Y wrong as well" doesn't make a convincing
argument :-P

[commit-bot: I haz the power, 2012-03-05 14:20:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/9490008/8001

[commit-bot: I haz the power, 2012-03-05 16:14:02]

Change committed as 124947