Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/libxml/libxml.gyp

Issue 9570054: clang: Add -Wno-empty-body to libxml and hunspell flags (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxml/libxml.gyp
diff --git a/third_party/libxml/libxml.gyp b/third_party/libxml/libxml.gyp
index f0c99f7604f602f1ffced2cb58a1b3ca30b36534..105ab87692dc5d026705cf13343071d336e0f9c7 100644
--- a/third_party/libxml/libxml.gyp
+++ b/third_party/libxml/libxml.gyp
@@ -197,10 +197,16 @@
'WARNING_CFLAGS': [
# libxml passes `const unsigned char*` through `const char*`.
'-Wno-pointer-sign',
+ # pattern.c and uri.c both have an intentional
+ # `for (...);` / `while(...);` loop. I submitted a patch to
+ # move the `'` to its own line, but until that's landed
+ # suppress the warning:
+ '-Wno-empty-body',
],
},
'cflags': [
'-Wno-pointer-sign',
+ '-Wno-empty-body',
],
}],
],
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698