Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/libxml/libxml.gyp

Issue 9570054: clang: Add -Wno-empty-body to libxml and hunspell flags (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'conditions': [ 7 'conditions': [
8 # Define an "os_include" variable that points at the OS-specific generated 8 # Define an "os_include" variable that points at the OS-specific generated
9 # headers. These were generated by running the configure script offline. 9 # headers. These were generated by running the configure script offline.
10 ['os_posix == 1 and OS != "mac"', { 10 ['os_posix == 1 and OS != "mac"', {
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 ['OS=="win"', { 190 ['OS=="win"', {
191 'product_name': 'libxml2', 191 'product_name': 'libxml2',
192 }, { # else: OS!="win" 192 }, { # else: OS!="win"
193 'product_name': 'xml2', 193 'product_name': 'xml2',
194 }], 194 }],
195 ['clang == 1', { 195 ['clang == 1', {
196 'xcode_settings': { 196 'xcode_settings': {
197 'WARNING_CFLAGS': [ 197 'WARNING_CFLAGS': [
198 # libxml passes `const unsigned char*` through `const char*`. 198 # libxml passes `const unsigned char*` through `const char*`.
199 '-Wno-pointer-sign', 199 '-Wno-pointer-sign',
200 # pattern.c and uri.c both have an intentional
201 # `for (...);` / `while(...);` loop. I submitted a patch to
202 # move the `'` to its own line, but until that's landed
203 # suppress the warning:
204 '-Wno-empty-body',
200 ], 205 ],
201 }, 206 },
202 'cflags': [ 207 'cflags': [
203 '-Wno-pointer-sign', 208 '-Wno-pointer-sign',
209 '-Wno-empty-body',
204 ], 210 ],
205 }], 211 }],
206 ], 212 ],
207 }], 213 }],
208 ], 214 ],
209 }, 215 },
210 ], 216 ],
211 } 217 }
OLDNEW
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698